Add node group autoscaling policy #3230
Conversation
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 35 insertions(+)) |
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 36 insertions(+)) |
| properties: | ||
| zone: !ruby/object:Overrides::Terraform::PropertyOverride | ||
| required: false | ||
| default_from_api: true | ||
| custom_flatten: 'templates/terraform/custom_flatten/name_from_self_link.erb' | ||
| autoscalingPolicy: !ruby/object:Overrides::Terraform::PropertyOverride |
There was a problem hiding this comment.
Do these need to all be O+C? Is the autoscalingPolicy block returned from the API even if it is undefined?
There was a problem hiding this comment.
Yeah the block was returning from the API in the basic test without autoscalingPolicy being set in the config, and was throwing a diff.
If the block IS defined, mode and maxNodes are required.
products/compute/api.yaml
Outdated
| - !ruby/object:Api::Type::Integer | ||
| name: 'minNodes' | ||
| description: | | ||
| Minimum size of the node group, and must be an integer value less |
There was a problem hiding this comment.
This is a little awkwardly worded. Maybe "Minimum size of the node group. Must be an ..."
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 1 file changed, 36 insertions(+)) |
* Add node group autoscaling policy * add default_from_api * Update api.yaml
Fixes hashicorp/terraform-provider-google#5628
Release Note Template for Downstream PRs (will be copied)